Model in library uses non-existent arctan function

[svorkoetter@…]

The model Modelica.Electrical.Analog.Basic.SaturatingInductor uses the non-existent function "arctan" in its equations. Thus, this model does not work. The bug exists in both MSL 3.0 and MSL 2.2.1.

[dietmarw]

Replying to svorkoetter@maplesoft.com:

The model Modelica.Electrical.Analog.Basic.SaturatingInductor uses the non-existent function "arctan" in its equations. Thus, this model does not work. The bug exists in both MSL 3.0 and MSL 2.2.1.

Yes it seems that here the Dymola specific function arctan() is used. That's probably also the reason this was overlooked (because it just works in Dymola). I did a short test and simply replacing arctan with the Modelica function atan should solve this. My example simulation gives the same result anyway.

Also I did a quick grep for usage of other Dymola specific arc* functions but didn't find any other occurrences. So I think this can be quite easily fixed for MSL3.0.1 and in 3.0 and 2.2.2 maintenance (not sure if 2.2.1 should also be maintained as 2.2.2 is fully compatible).

[otter]

Bug was fixed in r1148 in trunk version and in r1150 in MSL3.0 maintenance version.

[dietmarw]

Replying to otter:

Bug was fixed in r1148 in trunk version and in r1150 in MSL3.0 maintenance version.

Shouldn't this be fixed for 2.2.2 aswell?

[PHarman]

Likewise the model Modelica.Thermal.FluidHeatFlow.Components.Valve uses the function ln(x) which according to the specification should be log(x).

[stefanv]

Reopening due to previous comment.

[dietmarw]

Peter,
I'm creating a new ticket #94 from this since the person responsible for Modelica.Thermal.FluidHeatFlow.Components.Valve is actually Anton Haumer.

Stefan, I'll leave it at reopen since the 2.2.2 branch wasn't fixed yet.

[dietmarw]

Now also fixed for 2.2.2 maintenance branch in r1152 (code) and r1153 (release notes).