Ticket #18 (closed defect: fixed)

Opened 5 months ago

Last modified 3 months ago

Error in GenericJunction

Reported by: mdempsey Owned by: fcasella
Priority: normal Milestone: 1.0RC
Component: *unspecified* Severity: normal
Keywords: Cc:
Hide ticket: no

Description

The substance mass balance equation in GenericJunction has the indexing in to the ports_a_mXi_flow and ports_b_mXi_flow the wrong way around.

It is

    for i in 1:Medium.nXi loop
      sum(ports_a_mXi_flow[i,:])+sum(ports_b_mXi_flow[i,:]) = der(mXi[i])
        "Substance mass balance";
    end for;

but it should be

    for i in 1:Medium.nXi loop
      sum(ports_a_mXi_flow[:,i])+sum(ports_b_mXi_flow[:,i]) = der(mXi[i])
        "Substance mass balance";
    end for;

Change History

Changed 3 months ago by otter

  • status changed from new to closed
  • resolution set to fixed

Corrected in r1637

Changed 3 months ago by dietmarw

  • hide_ticket unset

Let's normal users have a look at the fixed issues.

Note: See TracTickets for help on using tickets.